issue_comments

Table actions

5 rows where issue = 1322198907 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Public API for setting new indexes: add a set_xindex method? · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1199939328 https://github.com/pydata/xarray/issues/6849#issuecomment-1199939328 https://api.github.com/repos/pydata/xarray/issues/6849 IC_kwDOAMm_X85HhZ8A shoyer 1217238 2022-07-29T20:56:05Z 2022-07-29T20:56:05Z MEMBER

I agree, I think only setting a few indexes at a time would be normal. If we eventually need convenience methods for setting multiple indexes we can add those later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Public API for setting new indexes: add a set_xindex method? 1322198907
1199868439 https://github.com/pydata/xarray/issues/6849#issuecomment-1199868439 https://api.github.com/repos/pydata/xarray/issues/6849 IC_kwDOAMm_X85HhIoX benbovy 4160723 2022-07-29T19:13:20Z 2022-07-29T19:13:20Z MEMBER

Hmm I'd rather expect that in most cases max. 2-3 (meta-)indexes are set, each from possibly a larger number of coordinates (e.g., 2-d staggered grid), but I could be wrong.

One exception could be setting (many) PandasIndex instances, one for each 1-d non-dimension coordinate of a Dataset. Maybe we could adapt .set_index() to support that case? Or later add a convenient method that "extends" default indexes to all 1-d coordinates if it turns out to be useful in many cases?

Another example would be to replace all default (pandas) indexes by Pint indexes. I guess that a convenient method accessible via the pint accessor would do the job well in that case?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Public API for setting new indexes: add a set_xindex method? 1322198907
1199762995 https://github.com/pydata/xarray/issues/6849#issuecomment-1199762995 https://api.github.com/repos/pydata/xarray/issues/6849 IC_kwDOAMm_X85Hgu4z keewis 14808389 2022-07-29T17:06:42Z 2022-07-29T17:06:42Z MEMBER

You can call set_xindex multiple times for that if needed.

I guess that depends on how many indexes you'd want to set at once? If that number is constant and small (like, 1-3) then that would be fine for me, but for anything else a bulk API would be great.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Public API for setting new indexes: add a set_xindex method? 1322198907
1199753281 https://github.com/pydata/xarray/issues/6849#issuecomment-1199753281 https://api.github.com/repos/pydata/xarray/issues/6849 IC_kwDOAMm_X85HgshB shoyer 1217238 2022-07-29T17:00:06Z 2022-07-29T17:00:06Z MEMBER

This sounds great to me!

I don't think we need support for setting multiple indexes at once in a single method call. You can call set_xindex multiple times for that if needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Public API for setting new indexes: add a set_xindex method? 1322198907
1199744559 https://github.com/pydata/xarray/issues/6849#issuecomment-1199744559 https://api.github.com/repos/pydata/xarray/issues/6849 IC_kwDOAMm_X85HgqYv keewis 14808389 2022-07-29T16:56:09Z 2022-07-29T16:56:09Z MEMBER

sounds good!

It would probably be good to figure out a way to extend it to accept multiple indexes at once, though, or have another method that allows that (if we think that set_xindex might support setting multiple indexes we should make sure the API can be extended).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Public API for setting new indexes: add a set_xindex method? 1322198907

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);