issue_comments

Table actions

8 rows where issue = 118711154 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Shift method for shifting data · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
161466950 https://github.com/pydata/xarray/pull/666#issuecomment-161466950 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE2MTQ2Njk1MA== shoyer 1217238 2015-12-02T23:32:16Z 2015-12-02T23:32:16Z MEMBER

The reasoning for moving coordinates with roll is that roll exists for use cases where the labels are already pretty much right but maybe wrap incorrectly. I'm thinking a longitude coordinate that formerly went from -180 to 180 and now should go from 0 to 360, or the result of applying a FFT.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
161452207 https://github.com/pydata/xarray/pull/666#issuecomment-161452207 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE2MTQ1MjIwNw== jhamman 2443309 2015-12-02T22:20:06Z 2015-12-02T22:20:06Z MEMBER

@shoyer - lgtm. go ahead and merge. I don't have strong feelings about the placement of coordinates so if you're okay with this, so am I.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
161442015 https://github.com/pydata/xarray/pull/666#issuecomment-161442015 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE2MTQ0MjAxNQ== jhamman 2443309 2015-12-02T21:39:23Z 2015-12-02T21:39:23Z MEMBER

@shoyer - I missed this one somehow and will give it a quick read through now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
161441136 https://github.com/pydata/xarray/pull/666#issuecomment-161441136 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE2MTQ0MTEzNg== shoyer 1217238 2015-12-02T21:35:40Z 2015-12-02T21:35:40Z MEMBER

Going to merge this shortly unless anyone else has feedback.

One possibly controversial API matter is that shift and roll follow different conventions for shifting coordinates -- shift keeps coordinates in place whereas roll moves them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
160543305 https://github.com/pydata/xarray/pull/666#issuecomment-160543305 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE2MDU0MzMwNQ== shoyer 1217238 2015-11-30T07:22:04Z 2015-11-30T07:22:04Z MEMBER

The last few commits implement roll, as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
160248244 https://github.com/pydata/xarray/pull/666#issuecomment-160248244 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE2MDI0ODI0NA== rabernat 1197350 2015-11-28T04:39:36Z 2015-11-28T04:39:36Z MEMBER

Seems cool to me!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
159493737 https://github.com/pydata/xarray/pull/666#issuecomment-159493737 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE1OTQ5MzczNw== shoyer 1217238 2015-11-25T05:10:24Z 2015-11-25T05:10:24Z MEMBER

I am curious about the decision to shift the variable data but not the coordinate. What is the anticipated use case for this?

This is similar to what DataFrame.shift does, adjusting the values but not the index.

I suppose the coordinates could go either way but it seemed simpler not to shift any of them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154
159481512 https://github.com/pydata/xarray/pull/666#issuecomment-159481512 https://api.github.com/repos/pydata/xarray/issues/666 MDEyOklzc3VlQ29tbWVudDE1OTQ4MTUxMg== rabernat 1197350 2015-11-25T03:46:00Z 2015-11-25T03:46:00Z MEMBER

I am curious about the decision to shift the variable data but not the coordinate. What is the anticipated use case for this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shift method for shifting data 118711154

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);