issue_comments

Table actions

6 rows where issue = 1177919687 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: body, reactions, created_at (date), updated_at (date)

issue 1

  • make more args kw only (except 'dim') · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1076832051 https://github.com/pydata/xarray/pull/6403#issuecomment-1076832051 https://api.github.com/repos/pydata/xarray/issues/6403 IC_kwDOAMm_X85ALycz Illviljan 14371165 2022-03-23T21:20:54Z 2022-03-23T21:21:43Z MEMBER

Yes, mypy found some issues with the ordering so moving to kwargs-only was my preferred solution. It indeed was a breaking change but I didn't think keep_attrs, axis, etc were that popular arguments either so I was not expecting too many noticing the change, and maybe just a note in the whats new would've been sufficient.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make more args kw only (except 'dim') 1177919687
1076676316 https://github.com/pydata/xarray/pull/6403#issuecomment-1076676316 https://api.github.com/repos/pydata/xarray/issues/6403 IC_kwDOAMm_X85ALMbc mathause 10194086 2022-03-23T18:26:35Z 2022-03-23T18:26:35Z MEMBER

From https://github.com/pydata/xarray/pull/5950#issuecomment-974719669

Keyword-only and some had the 3rd position arg as keep_attrs and in other cases it was axis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make more args kw only (except 'dim') 1177919687
1076611419 https://github.com/pydata/xarray/pull/6403#issuecomment-1076611419 https://api.github.com/repos/pydata/xarray/issues/6403 IC_kwDOAMm_X85AK8lb dcherian 2448579 2022-03-23T17:30:59Z 2022-03-23T17:30:59Z MEMBER

We might also want to do this for https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py

:+1: I lost track of it given that PR was open for so long. IIRC one issue is that the order of args was different forr Dataset.reduce vs DatasetGroupBy.reduce (cc @Illviljan)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make more args kw only (except 'dim') 1177919687
1076610125 https://github.com/pydata/xarray/pull/6403#issuecomment-1076610125 https://api.github.com/repos/pydata/xarray/issues/6403 IC_kwDOAMm_X85AK8RN mathause 10194086 2022-03-23T17:29:46Z 2022-03-23T17:29:46Z MEMBER

Sounds good - I'll add a deprecation.

We might also want to do this for https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make more args kw only (except 'dim') 1177919687
1076609267 https://github.com/pydata/xarray/pull/6403#issuecomment-1076609267 https://api.github.com/repos/pydata/xarray/issues/6403 IC_kwDOAMm_X85AK8Dz mathause 10194086 2022-03-23T17:29:01Z 2022-03-23T17:29:01Z MEMBER

Sounds good - I'll add a deprecation.

We might also want to do this for https://github.com/pydata/xarray/blob/main/xarray/core/_reductions.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make more args kw only (except 'dim') 1177919687
1076591151 https://github.com/pydata/xarray/pull/6403#issuecomment-1076591151 https://api.github.com/repos/pydata/xarray/issues/6403 IC_kwDOAMm_X85AK3ov max-sixty 5635139 2022-03-23T17:13:08Z 2022-03-23T17:13:08Z MEMBER

This is great, thanks @mathause .

From what I've seen in the wild, I do think we're going to get some breaks on some of these without a deprecation — e.g. I've rarely seen an n arg used for diff . What are your thoughts on the link that @gcaria posted in https://github.com/pydata/xarray/issues/5531? That might do the deprecation for us.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   make more args kw only (except 'dim') 1177919687

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);