issue_comments

Table actions

9 rows where issue = 1086346755 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Replace distutils.version with packaging.version · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1028303595 https://github.com/pydata/xarray/pull/6096#issuecomment-1028303595 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X849Sqrr keewis 14808389 2022-02-02T19:54:40Z 2022-02-02T19:54:40Z MEMBER

and we don't need packaging to build the package itself (e.g. the wheel), which is why we don't list it in pyproject.toml

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1028301979 https://github.com/pydata/xarray/pull/6096#issuecomment-1028301979 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X849SqSb jhamman 2443309 2022-02-02T19:52:31Z 2022-02-02T19:52:31Z MEMBER

@ax3l - The packaging dependency should be resolved in https://github.com/pydata/xarray/pull/6207.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1028297799 https://github.com/pydata/xarray/pull/6096#issuecomment-1028297799 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X849SpRH ax3l 1353258 2022-02-02T19:46:53Z 2022-02-02T19:46:53Z NONE

Don't you need to add packaging to your pyproject.toml in the toml [build-system] requires = [ ] section?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1000865482 https://github.com/pydata/xarray/pull/6096#issuecomment-1000865482 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X847p_7K mathause 10194086 2021-12-24T14:51:01Z 2021-12-24T14:51:01Z MEMBER

Thanks for the feedback!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1000384550 https://github.com/pydata/xarray/pull/6096#issuecomment-1000384550 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X847oKgm mathause 10194086 2021-12-23T15:41:46Z 2021-12-23T15:41:46Z MEMBER

:+1: thanks! I'll update the PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1000381435 https://github.com/pydata/xarray/pull/6096#issuecomment-1000381435 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X847oJv7 neutrinoceros 14075922 2021-12-23T15:35:51Z 2021-12-23T15:35:51Z NONE

parse was designed to be more resilient and produce LegacyVersion instances for packages that didn't use sane version strings. This functionality is going away because packaging devs judged that it causes more harm than good. In practice it seems that the Python landscape is now mature for this change, as sane version number schemes appear to be extremely dominant. So unless you know that you're parsing version numbers from packages that don't work with the plain Version class I don't think there's any reason to use parse now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1000373371 https://github.com/pydata/xarray/pull/6096#issuecomment-1000373371 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X847oHx7 mathause 10194086 2021-12-23T15:22:12Z 2021-12-23T15:22:12Z MEMBER

Note that packaging.version.parse will soon be effectively the same as calling packaging.version.Version

Actually, I would prefer Version(xr.__version__) > Version("0.20.1") over version.parse(xr.__version__) > version.parse("0.20.1") (mostly because I think it looks better...). However, it doesn't seem that this PR will be merged soon, though... Do you know if there any good reason for us to use parse over Version?

And I should still figure out if DuckArrayModule("pint").duck_array_version is used/ public.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
1000339097 https://github.com/pydata/xarray/pull/6096#issuecomment-1000339097 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X847n_aZ neutrinoceros 14075922 2021-12-23T14:24:35Z 2021-12-23T14:24:35Z NONE

Note that packaging.version.parse will soon be effectively the same as calling packaging.version.Version, see https://github.com/pypa/packaging/pull/407/files You might want to instantiate Version explicitly to avoid confusion in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755
999204074 https://github.com/pydata/xarray/pull/6096#issuecomment-999204074 https://api.github.com/repos/pydata/xarray/issues/6096 IC_kwDOAMm_X847jqTq max-sixty 5635139 2021-12-22T01:10:16Z 2021-12-22T01:10:16Z MEMBER

Thanks @mathause !

The current version.parse looks good (but the others are fine if you prefer ofc)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Replace distutils.version with packaging.version 1086346755

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);