issue_comments

Table actions

4 rows where issue = 1072473598 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Check for just ... in stack etc, and raise with a useful error message · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
988271086 https://github.com/pydata/xarray/issues/6051#issuecomment-988271086 https://api.github.com/repos/pydata/xarray/issues/6051 IC_kwDOAMm_X84659Hu dcherian 2448579 2021-12-07T21:20:51Z 2021-12-07T21:20:51Z MEMBER

— ... stands for x, y, not [x, y], and we're better to hold that line rather than have ... be a "mood of 'etc'".

Sounds good to me. "mood of 'etc'". is a great phrase!

I also agree with checking for ... and raising an error asking the user to enter [...]

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for just ... in stack etc, and raise with a useful error message 1072473598
987389688 https://github.com/pydata/xarray/issues/6051#issuecomment-987389688 https://api.github.com/repos/pydata/xarray/issues/6051 IC_kwDOAMm_X8462l74 max-sixty 5635139 2021-12-07T00:00:24Z 2021-12-07T00:00:24Z MEMBER

I see @mathause agrees, so I am v happy to be voted into the minority, but I would vote against it — ... stands for x, y, not [x, y], and we're better to hold that line rather than have ... be a "mood of 'etc'".

I would def be up for updating the error message to check for this mistake.

(I worry that when people disagree we can stay with the status quo, so I really would be fine doing this if you think it's better. Also I didn't get the release done yesterday so I should be downweighted 😁 )

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for just ... in stack etc, and raise with a useful error message 1072473598
987144668 https://github.com/pydata/xarray/issues/6051#issuecomment-987144668 https://api.github.com/repos/pydata/xarray/issues/6051 IC_kwDOAMm_X8461qHc dcherian 2448579 2021-12-06T20:04:04Z 2021-12-06T20:04:04Z MEMBER

Can we special-case ... and convert it to [...]?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for just ... in stack etc, and raise with a useful error message 1072473598
987126045 https://github.com/pydata/xarray/issues/6051#issuecomment-987126045 https://api.github.com/repos/pydata/xarray/issues/6051 IC_kwDOAMm_X8461lkd max-sixty 5635139 2021-12-06T19:47:04Z 2021-12-06T19:47:04Z MEMBER

It still needs to be in a list! Otherwise it would be funky to do flat=[x, ...]

python In [2]: import xarray as xr ...: ...: da = xr.DataArray([[1,2],[1,2]], dims=("x", "y")) ...: da.stack(flat=[...])

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check for just ... in stack etc, and raise with a useful error message 1072473598

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);