issue_comments: 883604872

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5624#issuecomment-883604872 https://api.github.com/repos/pydata/xarray/issues/5624 883604872 IC_kwDOAMm_X840qr2I 5635139 2021-07-20T18:28:54Z 2021-07-20T18:29:48Z MEMBER

Sorry to be late to the party here — I've been less in the flow of xarray for the past week.

How strongly do you feel about not having this as a dependency @shoyer ? I hadn't thought of it as controversial given it's a "official" python package, but without much confidence so happy to defer.

A few options: - Revert TypeGuard (when would we add it back — when typing-extensions has more track record? When 3.10 is our minimum version?) - Have typing-extensions be optional and add # type: ignore comments. Not sure how many would be required though. - Have typing-extensions be optional but raise an error on if TYPE_CHECKING if it's not installed — i.e. type checking will fail without it, but running xarray would be fine. - Make it a required dependency

If we can get a good error message, I would vote for requiring it for type-checking. If it silently swallows the error and doesn't type check, then I'd probably vote for reverting TypeGuard or making typing-extensions required.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   948890466