issue_comments: 802102704

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4977#issuecomment-802102704 https://api.github.com/repos/pydata/xarray/issues/4977 802102704 MDEyOklzc3VlQ29tbWVudDgwMjEwMjcwNA== 10194086 2021-03-18T16:47:52Z 2021-03-18T16:48:14Z MEMBER

It looked pretty good when I reviewed it, so :+1:

Just quickly skimming the code it did not become entirely clear to me why this had to be after dask/dask#7234? You don't import sliding_window_view from dask. Also you re-define sliding_window_view in dask_array_compat.py - why don't you need this in dask proper? (Not complaining just wondering. Also feel free to not answer the question if you don't have time.)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   819003369