home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 648266355

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4163#issuecomment-648266355 https://api.github.com/repos/pydata/xarray/issues/4163 648266355 MDEyOklzc3VlQ29tbWVudDY0ODI2NjM1NQ== 14808389 2020-06-23T16:14:44Z 2020-06-23T21:50:51Z MEMBER

unfortunately, this doesn't seem to really work: VariableSubtests was written to use the same tests for Variable and IndexVariable, and using it to test duckarrays (pint in particular) is difficult since the data that is often used to compare the result is not converted. I'm not sure if rewriting VariableSubtests to optionally allow converting the data or adding specific Variable-with-units tests instead of inheriting from VariableSubtests is easier...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  640740029
Powered by Datasette · Queries took 156.004ms · About: xarray-datasette