issue_comments: 647525098

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4163#issuecomment-647525098 https://api.github.com/repos/pydata/xarray/issues/4163 647525098 MDEyOklzc3VlQ29tbWVudDY0NzUyNTA5OA== 14808389 2020-06-22T13:38:14Z 2020-06-22T13:38:14Z MEMBER

except from the failing operator.eq tests (which are due to pint upstream and will be fixed soon) and the pad tests that need to be rewritten only the tests from the VariableSubclassobjects are left.

Since they use assert_array_equal and np.testing.assert_allclose (which don't dispatch), I'm not sure how to deal with them: If I wanted to fix them in TestVariable I would probably end up rewriting all of these. Other than that, I think we could also write our own version of assert_array_equal / assert_allclose that works on duck arrays. We already have the functionality in duck_array_ops.py, we'd just need to write the summary code. That would probably have to be a new PR, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   640740029