issue_comments: 645533305

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3975#issuecomment-645533305 https://api.github.com/repos/pydata/xarray/issues/3975 645533305 MDEyOklzc3VlQ29tbWVudDY0NTUzMzMwNQ== 14808389 2020-06-17T18:05:20Z 2020-06-17T18:20:11Z MEMBER

I just found another issue: pint implements prod (but not yet nanprod) so the prod tests could be un-xfailed. However, we define a custom nanprod function that uses where to replace nan with 1. This won't work on quantities since, unlike nan and 0, a bare 1 cannot be put into quantities with a dimension (i.e. with a unit other than dimensionless).

I don't really understand the purpose of nanprod's min_count parameter (and _maybe_null_out) so I'm not sure how to fix that.

For now, I think we can merge this PR on green and I'll add that issue to the list in #3594.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   600641276