issue_comments: 612132737

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3862#issuecomment-612132737 https://api.github.com/repos/pydata/xarray/issues/3862 612132737 MDEyOklzc3VlQ29tbWVudDYxMjEzMjczNw== 1217238 2020-04-10T17:26:40Z 2020-04-10T17:26:40Z MEMBER

is there a reason why this change wasn't incorporated into values.setter?

I'm not quite sure what you mean here. That's exactly what this change does, making assignment to IndexVariable.values an error.

If you were mutating .values on an indexed variable, then you already had a likely bug, because only part of xarray's data structures were being updated (the Variable, but not indexes). That's why we put this in as a bug fix -- see the linked issue https://github.com/pydata/xarray/issues/3470 for examples.

Unfortunately we couldn't figure out another way to make this work -- see https://github.com/pydata/xarray/issues/3470#issuecomment-566214653 for discussion. We're definitely open to alternatives if you can come up with them, though!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   582708100