issue_comments: 608340435
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/3922#issuecomment-608340435 | https://api.github.com/repos/pydata/xarray/issues/3922 | 608340435 | MDEyOklzc3VlQ29tbWVudDYwODM0MDQzNQ== | 5821660 | 2020-04-03T09:44:27Z | 2020-04-03T09:44:27Z | MEMBER | @keewis I checked with my datasets, works like a charm. I'll try to add dask tests for this as @shoyer suggested. Where should these tests go? Currently the idxmax/idxmin tests are in test_dataarray and test_dataset: https://github.com/pydata/xarray/blob/b3bafeefbd6e6d70bce505ae1f0d9d5a2b015089/xarray/tests/test_dataarray.py#L4512 Any pointers? |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
591101988 |