issue_comments: 572309210

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3654#issuecomment-572309210 https://api.github.com/repos/pydata/xarray/issues/3654 572309210 MDEyOklzc3VlQ29tbWVudDU3MjMwOTIxMA== 14808389 2020-01-08T23:32:53Z 2020-01-08T23:37:30Z MEMBER

this should be ready for review and merge.

Also, I found a few issues that I'm posting here so I won't forget about them: * documentation: - the examples of Variable.rolling_window pass a variable x that is not set anywhere and would change the results - the docstring of set_dims is quite confusing (to me, at least), it does not mention the shape parameter (which would be the same as passing a dictionary with values dict(zip(dims, shape)) to dims) or that broadcasting is used to expand if necessary (so no reshaping). * code: pad_with_fill_value seems to implement pad for dask arrays for all versions of dask, but at least for recent versions we should rely dask's implementation instead

I can update the documentation, but I'd leave the revisiting of the dask issues (there are a lot of them) to someone else.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   543276677