issue_comments: 424014244

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/1949#issuecomment-424014244 https://api.github.com/repos/pydata/xarray/issues/1949 424014244 MDEyOklzc3VlQ29tbWVudDQyNDAxNDI0NA== 10946756 2018-09-24T15:21:41Z 2018-09-24T15:50:19Z NONE

So does this mean that the following line in the docs is now false: "If a dimension name is given as an argument to drop, it also drops all variables that use that dimension"

This is at http://xarray.pydata.org/en/stable/data-structures.html#dataarray.

It does not seem to work as advertised. Before drop:

<xarray.Dataset> Dimensions: (Frequency: 2000, Index: 1, Power: 1, Temperature: 1) Coordinates: * Power (Power) float64 -117.0 * Temperature (Temperature) float64 1.16 * Index (Index) int64 0 * Frequency (Frequency) float64 3.865e+09 3.865e+09 3.865e+09 3.865e+09 ... Data variables: I (Power, Temperature, Index, Frequency) float64 ... Q (Power, Temperature, Index, Frequency) float64 ... Time (Power, Temperature, Index) datetime64[ns] ...

Then I call ds.drop('Frequency'), expecting that this will kill off the Frequency dimension, coordinate, and the I and Q variables, since they depend on Frequency, but what I get is:

<xarray.Dataset> Dimensions: (Frequency: 2000, Index: 1, Power: 1, Temperature: 1) Coordinates: * Power (Power) float64 -117.0 * Temperature (Temperature) float64 1.16 * Index (Index) int64 0 Dimensions without coordinates: Frequency Data variables: I (Power, Temperature, Index, Frequency) float64 ... Q (Power, Temperature, Index, Frequency) float64 ... Time (Power, Temperature, Index) datetime64[ns] ...

If I then try dropping Frequency again, it complains that there are no variables named 'Frequency'. So probably this issue should include an update to the documentation. Or maybe that should be a new issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   301031693