This line only applies to non-Dataset objects (see the isintance check on the line above), so I think we are OK here.

On Mon, May 28, 2018 at 9:05 PM Keisuke Fujii notifications@github.com wrote:

@fujiisoup commented on this pull request.

In xarray/core/merge.py https://github.com/pydata/xarray/pull/2162#discussion_r191300053:

 """
 from .dataset import Dataset
 from .dataarray import DataArray

• other = other.copy()
• for k, obj in other.items():
• if isinstance(obj, (Dataset, DataArray)):

• drop duplicated coordinates

• coord_names = [c for c in obj.coords
• if c not in obj.dims and c in dataset.coords]
• if coord_names:
• other[k] = obj.drop(coord_names)
• if not isinstance(other, Dataset):
• other = OrderedDict(other)

I am slightly wondering this behavior may change after we finally support

884 https://github.com/pydata/xarray/issues/884, i.e. we will not

include coordinates in .key().

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2162#pullrequestreview-123842932, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1gLkp5aD26C7wH18rk_zdfk9h5Kdks5t3Mj0gaJpZM4UFEGE .