issue_comments: 391937921

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2162#issuecomment-391937921 https://api.github.com/repos/pydata/xarray/issues/2162 391937921 MDEyOklzc3VlQ29tbWVudDM5MTkzNzkyMQ== 1217238 2018-05-25T04:30:21Z 2018-05-25T04:30:21Z MEMBER

Yes, if other is a Dataset coordinates get overwritten. We probably already had test coverage for this, but I also added some explicit tests. On Thu, May 24, 2018 at 9:21 PM Keisuke Fujii notifications@github.com wrote:

Do we update coordinates if other is Dataset?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2162#issuecomment-391936961, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1v2WCnW59lZwnW_nc2oQftwaZTgVks5t14bNgaJpZM4UFEGE . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   324486173