issue_comments: 390630714

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2162#issuecomment-390630714 https://api.github.com/repos/pydata/xarray/issues/2162 390630714 MDEyOklzc3VlQ29tbWVudDM5MDYzMDcxNA== 6815844 2018-05-21T11:41:16Z 2018-05-23T00:57:05Z MEMBER

I didn't notice that iterating over dataset gives a FutureWarning.

Do you agree that we should have different behavior for overriding coords with setitem vs. update()?

I actually do not yet understand well the difference between ds.update(other) and ds.merge(other).

The docs says

If any dimensions would have inconsistent sizes in the updated dataset.update raises a ValueError,

but it does not. Maybe it should work identically with xr.merge(other)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   324486173