home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 368343446

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1936#issuecomment-368343446 https://api.github.com/repos/pydata/xarray/issues/1936 368343446 MDEyOklzc3VlQ29tbWVudDM2ODM0MzQ0Ng== 1217238 2018-02-25T20:51:36Z 2018-02-25T20:51:36Z MEMBER

I also find it quite noisy and not very encouraging to submit PRs at an early "quick n dirty" stage, where you really shouldn't care about pep8...

I agree, but the alternative is to get a failed build error, and it can be a pain to dig through the Travis-CI to find out what went wrong. We use automated comments like this at work to enforce style, and on the whole I think they're probably a good thing.

I would certainly encourage contributors not to worry about these errors until they think their code is ready to submit.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  299601789
Powered by Datasette · Queries took 238.65ms · About: xarray-datasette