home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 343167809

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/1705#issuecomment-343167809 https://api.github.com/repos/pydata/xarray/issues/1705 343167809 MDEyOklzc3VlQ29tbWVudDM0MzE2NzgwOQ== 6815844 2017-11-09T14:19:04Z 2017-11-09T14:19:04Z MEMBER

This looks pretty clean and less error-prone.

For more cleanliness, I'm wondering if we could more clearly distinguish between raw array-wrappers (such as NumpyIndexingAdapter) and wrappers of array-wrapper (such as MemoryCachedArray). But as a whole, I like this idea.

Regarding the more array-type support in the future (as suggested in comment), is there something to prepare in this PR? I guess there are some typical indexing types, such as Fortran-type and Numpy-type. Can we have some abstract classes (maybe too early)?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  272460887
Powered by Datasette · Queries took 0.662ms · About: xarray-datasette