issue_comments: 155530747

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/648#issuecomment-155530747 https://api.github.com/repos/pydata/xarray/issues/648 155530747 MDEyOklzc3VlQ29tbWVudDE1NTUzMDc0Nw== 2443309 2015-11-10T18:56:07Z 2015-11-10T18:56:07Z MEMBER

@shoyer - I read this mainly trying to get a better idea of the internal DataArray data model. The code itself looks great. My main two comments on the refactor are: 1. The use of the _ThisArray singleton seems a bit clunky to me. This is my first time interacting with this approach so maybe it is the best way, but I don't know much about it. 2. This all seems to be complicated by the DataArrays's use of the Dataset internally to store coordinates. Not for this PR, but I wonder if there is a way to clear up the lines between the two objects.

All in all, impressive work.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   115805419