issue_comments: 1071053923

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/6373#issuecomment-1071053923 https://api.github.com/repos/pydata/xarray/issues/6373 1071053923 IC_kwDOAMm_X84_1vxj 2443309 2022-03-17T16:30:25Z 2022-03-17T16:30:25Z MEMBER

It would be nice to avoid this process but I think we need to keep it. Without extract_zarr_variable_encoding and checks against a valid set of options, we have no way to filter out encoding keys that do not apply to the backend. By way of an example:

python In [1]: import xarray as xr In [2]: ds = xr.tutorial.open_dataset('rasm').chunk('100mb') In [3]: ds.Tair.encoding Out[3]: {'source': '/Users/jhamman/Library/Caches/xarray_tutorial_data/eee06791cc19e59f074155a82a7ffe90-rasm.nc', 'original_shape': (36, 205, 275), 'dtype': dtype('float64'), '_FillValue': 9.969209968386869e+36, 'coordinates': 'yc xc'}

Passing most of these to zarr.create would result in a UserWarning. We could inpspect zarr.create to pull the list of valid arguments but I think it is probably cleaner to just list the expected arguments as we do. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1171932478