html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4977#issuecomment-802131062,https://api.github.com/repos/pydata/xarray/issues/4977,802131062,MDEyOklzc3VlQ29tbWVudDgwMjEzMTA2Mg==,2448579,2021-03-18T17:10:28Z,2021-03-18T17:10:28Z,MEMBER,thanks @andersy005 !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369
https://github.com/pydata/xarray/pull/4977#issuecomment-802123636,https://api.github.com/repos/pydata/xarray/issues/4977,802123636,MDEyOklzc3VlQ29tbWVudDgwMjEyMzYzNg==,13301940,2021-03-18T17:06:46Z,2021-03-18T17:06:46Z,MEMBER,"@dcherian, should we test this in upstream-dev CI workflow (via the `[test-upstream]` keyword)? 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369
https://github.com/pydata/xarray/pull/4977#issuecomment-802112978,https://api.github.com/repos/pydata/xarray/issues/4977,802112978,MDEyOklzc3VlQ29tbWVudDgwMjExMjk3OA==,2448579,2021-03-18T17:01:34Z,2021-03-18T17:01:34Z,MEMBER,"> You don't import sliding_window_view from dask.

haha. fixed!

I was waiting on that PR to see if the reviews would catch any bugs.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369
https://github.com/pydata/xarray/pull/4977#issuecomment-802102704,https://api.github.com/repos/pydata/xarray/issues/4977,802102704,MDEyOklzc3VlQ29tbWVudDgwMjEwMjcwNA==,10194086,2021-03-18T16:47:52Z,2021-03-18T16:48:14Z,MEMBER,"It looked pretty good when I reviewed it, so :+1: 

Just quickly skimming the code it did not become entirely clear to me why this had to be after dask/dask#7234? You don't import `sliding_window_view` from dask. Also you re-define `sliding_window_view` in `dask_array_compat.py` - why don't you need this in dask proper? (Not complaining just wondering. Also feel free to not answer the question if you don't have time.)

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369
https://github.com/pydata/xarray/pull/4977#issuecomment-802084481,https://api.github.com/repos/pydata/xarray/issues/4977,802084481,MDEyOklzc3VlQ29tbWVudDgwMjA4NDQ4MQ==,2448579,2021-03-18T16:31:13Z,2021-03-18T16:31:13Z,MEMBER,The dask PR was merged so this should be ready to go.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369
https://github.com/pydata/xarray/pull/4977#issuecomment-798782767,https://api.github.com/repos/pydata/xarray/issues/4977,798782767,MDEyOklzc3VlQ29tbWVudDc5ODc4Mjc2Nw==,2448579,2021-03-13T20:43:43Z,2021-03-13T20:44:14Z,MEMBER,"> I am still interested to eventually fix #2007. This PR may also make that easier as it now uses Variable.pad.

That's the goal i.e. make it easier to fix #2007 and minimize number of code paths for rolling. This PR reduces the number of places we call `pad` from 4 to 3 :P. The two bottleneck code paths still do their own padding.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369
https://github.com/pydata/xarray/pull/4977#issuecomment-788271567,https://api.github.com/repos/pydata/xarray/issues/4977,788271567,MDEyOklzc3VlQ29tbWVudDc4ODI3MTU2Nw==,2448579,2021-03-01T20:54:36Z,2021-03-01T20:54:36Z,MEMBER,`sliding_window_view` dispatches with array_function so we could support other duck array libraries if they implemented it. cc @keewis,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819003369