html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4532#issuecomment-717494320,https://api.github.com/repos/pydata/xarray/issues/4532,717494320,MDEyOklzc3VlQ29tbWVudDcxNzQ5NDMyMA==,5635139,2020-10-27T19:48:50Z,2020-10-27T19:48:50Z,MEMBER,Excellent PR @Illviljan ! Thank you. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-715910031,https://api.github.com/repos/pydata/xarray/issues/4532,715910031,MDEyOklzc3VlQ29tbWVudDcxNTkxMDAzMQ==,24736507,2020-10-24T12:46:55Z,2020-10-27T19:47:46Z,NONE,"Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:





There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: 

##### Comment last updated at 2020-10-27 19:47:45 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716221826,https://api.github.com/repos/pydata/xarray/issues/4532,716221826,MDEyOklzc3VlQ29tbWVudDcxNjIyMTgyNg==,14808389,2020-10-25T22:20:35Z,2020-10-25T22:20:35Z,MEMBER,"> is that `DataArray.units` doesn't exist

it doesn't, but `napoleon` doesn't check whether the manually declared attributes actually exist. The issue is that the string
```
    Attributes:
        description:  Ambient temperature.
        units:        degC
```
appears twice which makes `napoleon` with a enabled `googledoc` generate two `Attributes` sections. It is weird that `description:` doesn't trigger the same warning as `units:`, though.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716219715,https://api.github.com/repos/pydata/xarray/issues/4532,716219715,MDEyOklzc3VlQ29tbWVudDcxNjIxOTcxNQ==,5635139,2020-10-25T22:05:00Z,2020-10-25T22:05:00Z,MEMBER,"OK. 

Tangentially — one weirdness is that `DataArray.units` doesn't exist, I think...","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716218968,https://api.github.com/repos/pydata/xarray/issues/4532,716218968,MDEyOklzc3VlQ29tbWVudDcxNjIxODk2OA==,14808389,2020-10-25T21:59:30Z,2020-10-25T21:59:30Z,MEMBER,"my guess is that `Attributes:` is picked up by the google-style parser, which is enabled by default. To fix that, we could try to explicitly enable numpydoc and disable the googledoc parser in `conf.py`:
```python
napoleon_numpy_docstring = True
napoleon_google_docstring = False
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716216586,https://api.github.com/repos/pydata/xarray/issues/4532,716216586,MDEyOklzc3VlQ29tbWVudDcxNjIxNjU4Ng==,5635139,2020-10-25T21:40:56Z,2020-10-25T21:40:56Z,MEMBER,@Illviljan I moved the whatsnew to 0.16.2 — you should pull from your branch to get the changes. You don't need to do anything else.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716212788,https://api.github.com/repos/pydata/xarray/issues/4532,716212788,MDEyOklzc3VlQ29tbWVudDcxNjIxMjc4OA==,5635139,2020-10-25T21:12:46Z,2020-10-25T21:12:46Z,MEMBER,"Hmmm, nor do I.

@keewis might you recognize that error?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716211610,https://api.github.com/repos/pydata/xarray/issues/4532,716211610,MDEyOklzc3VlQ29tbWVudDcxNjIxMTYxMA==,14371165,2020-10-25T21:03:19Z,2020-10-25T21:03:19Z,MEMBER,"Yeah, I don't get this one. The dataset version didn't get this error for some reason","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716209042,https://api.github.com/repos/pydata/xarray/issues/4532,716209042,MDEyOklzc3VlQ29tbWVudDcxNjIwOTA0Mg==,5635139,2020-10-25T20:43:39Z,2020-10-25T20:43:39Z,MEMBER,"Docs are raising a warning: `/home/docs/checkouts/readthedocs.org/user_builds/xray/checkouts/4532/xarray/core/dataarray.py:docstring of xarray.DataArray:121: WARNING: duplicate object description of xarray.DataArray.units, other instance in generated/xarray.DataArray, use :noindex: for one of them` — lmk if you need a hand figuring it out.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405
https://github.com/pydata/xarray/pull/4532#issuecomment-716207227,https://api.github.com/repos/pydata/xarray/issues/4532,716207227,MDEyOklzc3VlQ29tbWVudDcxNjIwNzIyNw==,5635139,2020-10-25T20:30:22Z,2020-10-25T20:30:22Z,MEMBER,"Excellent @Illviljan !

Would you like to add a line under Documentation in the `whatsnew`, giving yourself credit? Then I'll merge","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,728782405