html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3611#issuecomment-596374671,https://api.github.com/repos/pydata/xarray/issues/3611,596374671,MDEyOklzc3VlQ29tbWVudDU5NjM3NDY3MQ==,2448579,2020-03-09T07:40:40Z,2020-03-09T07:40:40Z,MEMBER,"Yeah, thanks @keewis ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533
https://github.com/pydata/xarray/pull/3611#issuecomment-596027950,https://api.github.com/repos/pydata/xarray/issues/3611,596027950,MDEyOklzc3VlQ29tbWVudDU5NjAyNzk1MA==,5635139,2020-03-07T01:23:53Z,2020-03-07T01:23:53Z,MEMBER,"Looks good! 
(as ever with me & this section of code, without being that confident)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533
https://github.com/pydata/xarray/pull/3611#issuecomment-596025596,https://api.github.com/repos/pydata/xarray/issues/3611,596025596,MDEyOklzc3VlQ29tbWVudDU5NjAyNTU5Ng==,14808389,2020-03-07T01:06:47Z,2020-03-07T01:06:47Z,MEMBER,"This should be ready for review / merge once again.

It seems that after the merge of #3706 all that was left to get the top-level function tests to pass was to clean up those tests.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533
https://github.com/pydata/xarray/pull/3611#issuecomment-567275273,https://api.github.com/repos/pydata/xarray/issues/3611,567275273,MDEyOklzc3VlQ29tbWVudDU2NzI3NTI3Mw==,14808389,2019-12-19T00:34:12Z,2019-12-19T00:34:12Z,MEMBER,"I added a `whats-new.rst` entry, but I'm not sure if it is too minimal.

If this is okay for now, we could merge?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533
https://github.com/pydata/xarray/pull/3611#issuecomment-565411716,https://api.github.com/repos/pydata/xarray/issues/3611,565411716,MDEyOklzc3VlQ29tbWVudDU2NTQxMTcxNg==,5635139,2019-12-13T11:41:53Z,2019-12-13T11:41:53Z,MEMBER,"Thanks for the review @dcherian !

@keewis FYI I am starting a new job so will be lying low on xarray for a couple of months, forgive the temporary pause in speedy reviews. It was great to work together for the past few months! 

The whole team is looking forward to working more closely with you in the future. We'd like to invite you to be a maintainer: could you drop me an email at `m` at `maxroos` period `com`?

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533
https://github.com/pydata/xarray/pull/3611#issuecomment-564906552,https://api.github.com/repos/pydata/xarray/issues/3611,564906552,MDEyOklzc3VlQ29tbWVudDU2NDkwNjU1Mg==,14808389,2019-12-12T08:40:20Z,2019-12-12T08:40:20Z,MEMBER,"the `_getitem_with_mask` failures are due to `bool` not defining `__invert__`, which means it falls back to `int.__invert__`. I special-cased it, but we could also modify `indexing.create_mask` to always return a duck array.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533
https://github.com/pydata/xarray/pull/3611#issuecomment-564757094,https://api.github.com/repos/pydata/xarray/issues/3611,564757094,MDEyOklzc3VlQ29tbWVudDU2NDc1NzA5NA==,14808389,2019-12-11T22:13:11Z,2019-12-11T22:45:48Z,MEMBER,"it seems the changes to `Variable._getitem_with_mask` will make other tests fail. The reason for the changes is that pint will convert every argument of `np.where` to the first argument's units, which would convert the array to the fill value's units and would be quite unexpected, I think?. Does anyone know what to do here?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,536639533