html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2162#issuecomment-392650194,https://api.github.com/repos/pydata/xarray/issues/2162,392650194,MDEyOklzc3VlQ29tbWVudDM5MjY1MDE5NA==,6815844,2018-05-29T04:33:50Z,2018-05-29T04:33:50Z,MEMBER,"I just missed this line.
Thanks.
LGTM.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-392650084,https://api.github.com/repos/pydata/xarray/issues/2162,392650084,MDEyOklzc3VlQ29tbWVudDM5MjY1MDA4NA==,1217238,2018-05-29T04:32:44Z,2018-05-29T04:32:44Z,MEMBER,"This line only applies to non-Dataset objects (see the isintance check on
the line above), so I think we are OK here.
On Mon, May 28, 2018 at 9:05 PM Keisuke Fujii
wrote:
> *@fujiisoup* commented on this pull request.
> ------------------------------
>
> In xarray/core/merge.py
> :
>
> > """"""
> from .dataset import Dataset
> from .dataarray import DataArray
>
> - other = other.copy()
> - for k, obj in other.items():
> - if isinstance(obj, (Dataset, DataArray)):
> - # drop duplicated coordinates
> - coord_names = [c for c in obj.coords
> - if c not in obj.dims and c in dataset.coords]
> - if coord_names:
> - other[k] = obj.drop(coord_names)
> + if not isinstance(other, Dataset):
> + other = OrderedDict(other)
>
> I am slightly wondering this behavior may change after we finally support
> #884 , i.e. we will not
> include coordinates in .key().
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-392645688,https://api.github.com/repos/pydata/xarray/issues/2162,392645688,MDEyOklzc3VlQ29tbWVudDM5MjY0NTY4OA==,1217238,2018-05-29T03:54:35Z,2018-05-29T03:54:35Z,MEMBER,I plan to merge this shortly (with a day or two) unless anyone else has comments,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-391937921,https://api.github.com/repos/pydata/xarray/issues/2162,391937921,MDEyOklzc3VlQ29tbWVudDM5MTkzNzkyMQ==,1217238,2018-05-25T04:30:21Z,2018-05-25T04:30:21Z,MEMBER,"Yes, if other is a Dataset coordinates get overwritten. We probably already
had test coverage for this, but I also added some explicit tests.
On Thu, May 24, 2018 at 9:21 PM Keisuke Fujii
wrote:
> Do we update coordinates if other is Dataset?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-391936961,https://api.github.com/repos/pydata/xarray/issues/2162,391936961,MDEyOklzc3VlQ29tbWVudDM5MTkzNjk2MQ==,6815844,2018-05-25T04:21:33Z,2018-05-25T04:21:33Z,MEMBER,Do we update coordinates if other is Dataset?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-391935599,https://api.github.com/repos/pydata/xarray/issues/2162,391935599,MDEyOklzc3VlQ29tbWVudDM5MTkzNTU5OQ==,1217238,2018-05-25T04:09:30Z,2018-05-25T04:09:30Z,MEMBER,"OK, updated to only silence the warning in `Dataset.update(Dataset)` (by refactoring the logic)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-391447131,https://api.github.com/repos/pydata/xarray/issues/2162,391447131,MDEyOklzc3VlQ29tbWVudDM5MTQ0NzEzMQ==,1217238,2018-05-23T18:16:03Z,2018-05-25T04:07:04Z,MEMBER,- [x] make a decision on coordinate conflicts with `update()`,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-390630714,https://api.github.com/repos/pydata/xarray/issues/2162,390630714,MDEyOklzc3VlQ29tbWVudDM5MDYzMDcxNA==,6815844,2018-05-21T11:41:16Z,2018-05-23T00:57:05Z,MEMBER,"I didn't notice that iterating over dataset gives a FutureWarning.
> Do you agree that we should have different behavior for overriding coords with __setitem__ vs. update()?
I actually do not yet understand well the difference between `ds.update(other)` and `ds.merge(other)`.
The docs says
> If any dimensions would have inconsistent sizes in the updated dataset.update raises a ValueError,
but it does not.
Maybe it should work identically with `xr.merge(other)`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173
https://github.com/pydata/xarray/pull/2162#issuecomment-390583609,https://api.github.com/repos/pydata/xarray/issues/2162,390583609,MDEyOklzc3VlQ29tbWVudDM5MDU4MzYwOQ==,1217238,2018-05-21T08:06:12Z,2018-05-21T08:06:12Z,MEMBER,"@fujiisoup any thoughts?
Do you agree that we should have different behavior for overriding `coords` with `__setitem__` vs. `update()`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,324486173