pull_requests: 970824245
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 970824245 | PR_kwDOAMm_X8453Zo1 | 6702 | closed | 0 | Typing of GroupBy & Co. | 43316012 | This PR adds typing support for groupby, coarsen, rolling, weighted and resample. There are several open points: 1. Coarsen is missing type annotations for reductions like `max`, they get added dynamically. 2. The `Groupby` group-key type is quite wide. Does anyone have any idea on how to type it correctly? For now it is still Any. 3. Several function signatures were inconsistent between the DataArray and Dataset versions (looking at you: `map`). I took the freedom to align them (required for mypy), hopefully this does not break too much. 4. I was moving the generation functions from `DataWithCoords` to `DataArray` and `Dataset`, which adds some copy-paste of code (I tried to keep it minimal) but was unavoidable for typing support. (Adds the bonus that the corresponding modules are now only imported when required). | 2022-06-17T16:50:43Z | 2022-07-03T13:32:30Z | 2022-06-29T20:06:04Z | 2022-06-29T20:06:04Z | b5207aa0bf2f3297d7c34d6daf29c9ea9dcefdde | 0 | 4d9c4595f09ff9802bde7a56c815069fc5e604ea | aef5377a5af33a635a651123af7caa7435c24931 | COLLABORATOR | 13221727 | https://github.com/pydata/xarray/pull/6702 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests