pull_requests: 957579117

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
957579117 PR_kwDOAMm_X845E39t 6661 closed 0 Typing of Dataset 43316012 - [x] Closes #5945 - [x] Tests added Feel free to wait with merging after the 2022.05.0.dev0 release :) - This PR adds typing to all Dataset methods (only the ones in Dataset directly and DataWithCoords). - On the way it fixes several typing issues and adds small code changes for more consistent typing (hopefully does not break anything). - All test_dataset tests are now typed. - As usual there are still some mypy bugs open that prevent all typing changes to be final (especially https://github.com/python/mypy/issues/12846). I choose to remove the TypeVars in these occasions to prevent false positives on the user side. - Sorry for updating so many files at once, mostly these are the changes of adding `from __future__ import annotations` and automatic fixes from pyupdate. If anyone has some typing expertise: I think that the way align is typed is wrong. The current implementation only works for aligning a sequence of objects of the same type, but not mixed DataArrays and Datasets. In some placed I had to add some "#type: ignore"s... I should probably open an issue for that. 2022-06-03T15:22:24Z 2022-06-04T10:17:48Z 2022-06-04T04:26:03Z 2022-06-04T04:26:03Z a2edbe4bfcba5509f8a3119322dc7794defdbc8c     0 6889810ce1bdb363cb184a52f213859283bf4923 7bdb0e4456d0add8e94461dba0e7c0a160cc5812 COLLABORATOR   13221727 https://github.com/pydata/xarray/pull/6661  

Links from other tables