pull_requests: 947243367
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 947243367 | PR_kwDOAMm_X844dcln | 6636 | closed | 0 | Use `zarr` to validate attrs when writing to zarr | 22245117 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #6448 - [x] Tests added - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - ~New functions/methods are listed in `api.rst`~ I think we can just use zarr to validate attributes, so we can support all types allowed by zarr. Note that I removed the checks on the keys, as I believe we can rely on zarr for that as well. However, there is an issue with mixed types (e.g., `attrs={"a": "foo", 1: "foo"}`), but I think that needs to be addressed in zarr. See: https://github.com/zarr-developers/zarr-python/issues/1037 cc: @wankoelias @rabernat | 2022-05-25T16:46:03Z | 2022-06-03T18:48:54Z | 2022-06-03T18:48:48Z | 2022-06-03T18:48:47Z | b080349c5d33d2e97ffce504cc2e8c9516d60d29 | 0 | cc6786ed8d63d264ce736518097501a9fdf557d0 | 3b242a184072db9928ede7b72c07f047cd67d23b | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/6636 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests