pull_requests: 936771594

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
936771594 PR_kwDOAMm_X8431gAK 6611 closed 0 {full,zeros,ones}_like typing 43316012 (partial) typing for functions `full_like`, `zeros_like`, `ones_like`. I could not figure out how to properly use TypeVars so many things are "hardcoded" with overloads. I have added a `DTypeLikeSave` to `npcompat`, not sure that this file is supposed to be edited. Problem1: `TypeVar["T", Dataset, DataArray, Variable]` can only be one of these three, but never with `Union[Dataset, DataArray]` which is used in several other places in xarray. Problem2: The official mypy support says: use `TypeVar["T", bound=Union[Dataset, DataArray, Variable]` but the the `isinstance(obj, Dataset)` could not be correctly resolved (is that a mypy issue?). So if anyone can get it to work with TypeVars, feel free to change it. :) 2022-05-15T15:18:55Z 2022-05-16T18:10:05Z 2022-05-16T17:42:25Z 2022-05-16T17:42:25Z e712270f9dd4df811517f9e44e9465255aa18709     0 da5bd9b5b751e999f7c16ed40137a3cc8f662e51 8de706151e183f448e1af9115770713d18e229f1 COLLABORATOR 
{
    "enabled_by": {
        "login": "max-sixty",
        "id": 5635139,
        "node_id": "MDQ6VXNlcjU2MzUxMzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/5635139?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/max-sixty",
        "html_url": "https://github.com/max-sixty",
        "followers_url": "https://api.github.com/users/max-sixty/followers",
        "following_url": "https://api.github.com/users/max-sixty/following{/other_user}",
        "gists_url": "https://api.github.com/users/max-sixty/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/max-sixty/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/max-sixty/subscriptions",
        "organizations_url": "https://api.github.com/users/max-sixty/orgs",
        "repos_url": "https://api.github.com/users/max-sixty/repos",
        "events_url": "https://api.github.com/users/max-sixty/events{/privacy}",
        "received_events_url": "https://api.github.com/users/max-sixty/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "{full,zeros,ones}_like typing (#6611)",
    "commit_message": "* type {full,zeros,ones}_like\r\n\r\n* fix modern numpy\r\n\r\n* [pre-commit.ci] auto fixes from pre-commit.com hooks\r\n\r\nfor more information, see https://pre-commit.ci\r\n\r\n* python3.8 support\r\n\r\n* [pre-commit.ci] auto fixes from pre-commit.com hooks\r\n\r\nfor more information, see https://pre-commit.ci\r\n\r\n* fix typo\r\n\r\n* apply patch from max-sixty\r\n\r\n* add link to numpy.typing.DTypeLike\r\n\r\nCo-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>"
}
 13221727 https://github.com/pydata/xarray/pull/6611  

Links from other tables