home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 93553990

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
93553990 MDExOlB1bGxSZXF1ZXN0OTM1NTM5OTA= 1118 closed 0 Do not convert subclasses of `ndarray` unless required 1310437 By changing a single `np.asarray` to `np.asanyarray`, it becomes possible to use `ndarray` subclasses within `DataArray` and `Dataset`. No guarantee is made at this point that their behaviour is retained under all circumstances, but for some use-cases it will work. Particularly, this allows to store physical quantities represented using the `Quantity` subclass from the package [python-quantities](https://github.com/python-quantities/python-quantities). In that sense, it is a partial fix for #525. Tests are included to highlight some of the things that do work, and some which don't. It does not work for coordinates when they are used as indexes, since pandas does not support ndarray subclasses. Most likely, it will also not work for any higher-level operation on the data such as those involving `np.concatenate`. Thus, any user of this feature should remain cautious. Nonetheless, for me, this change provides enough added value, such that I'd consider it worthwhile to keep, assuming it does not harm anywhere else. It does pass the tests on my machine (no dask though), let's see what travis says. I expect that astropy's units would behave similarly, though since I never worked with them yet, I did not include any tests. 2016-11-14T11:59:02Z 2019-12-25T14:12:34Z 2019-12-25T14:12:34Z   05a025614cd7267537dfe9025a681c33575fb49a     0 c58f92ebccf76253d2eed6b9ec48b835a389209f bb87a9441d22b390e069d0fde58f297a054fd98a CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/1118  

Links from other tables

  • 1 row from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 4.621ms