pull_requests: 887039314

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
887039314 PR_kwDOAMm_X8403yVS 6403 closed 0 make more args kw only (except 'dim') 10194086 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` This makes many arguments keyword-only, except for `dim` to avoid `da.weighted(...).mean("lat", "lon")` (i.e. `da.weighted(...).mean(dim="lat", skipna="lon")`) which silently does the wrong thing. I am sure I forgot some and for some I was unsure so I left them as is. Question: do we want an deprecation cycle? Currently it just errors for `da.weighted(...).mean("dim", True)`. Might be nice to do it, however, @dcherian if I am not mistaken you did this without a deprecation in #5950, e.g. for `da.mean` etc.? ```python import numpy as np import xarray as xr air = xr.tutorial.open_dataset("air_temperature") wgt = np.cos(np.deg2rad(air.lat)) air.weighted(wgt).mean("lat", "lon") ``` 2022-03-23T10:28:02Z 2023-10-05T20:38:49Z 2023-10-05T20:38:49Z 2023-10-05T20:38:49Z 938579dbf7360c7d760ee7c6d3ffb2753bfa92e4     0 3a52a973c9a95037d872bde4c6dc8fe9264c9feb e09609c234590dffb1b46c8526c3524da561c0ec MEMBER 
{
    "enabled_by": {
        "login": "dcherian",
        "id": 2448579,
        "node_id": "MDQ6VXNlcjI0NDg1Nzk=",
        "avatar_url": "https://avatars.githubusercontent.com/u/2448579?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/dcherian",
        "html_url": "https://github.com/dcherian",
        "followers_url": "https://api.github.com/users/dcherian/followers",
        "following_url": "https://api.github.com/users/dcherian/following{/other_user}",
        "gists_url": "https://api.github.com/users/dcherian/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/dcherian/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/dcherian/subscriptions",
        "organizations_url": "https://api.github.com/users/dcherian/orgs",
        "repos_url": "https://api.github.com/users/dcherian/repos",
        "events_url": "https://api.github.com/users/dcherian/events{/privacy}",
        "received_events_url": "https://api.github.com/users/dcherian/received_events",
        "type": "User",
        "site_admin": false
    },
    "merge_method": "squash",
    "commit_title": "make more args kw only (except 'dim') (#6403)",
    "commit_message": "* make more args kw only (except 'dim')\r\n\r\n* add deprecation\r\n\r\n* add forgotten deprecations\r\n\r\n* doctest fixes\r\n\r\n* fix some warnings\r\n\r\n* remove expand_dims again\r\n\r\n* undo expand_dims, fix mypy\r\n\r\n* whats-new entry [skip-ci]\r\n\r\n* add typing to _deprecate_positional_args helper\r\n\r\n* Update xarray/util/deprecation_helpers.py\r\n\r\nCo-authored-by: Michael Niklas  <mick.niklas@gmail.com>\r\n\r\n* fix kw only for overload\r\n\r\n* move typing\r\n\r\n* restore # type: ignore\r\n\r\n* add type ignores to test_deprecation_helpers\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Niklas <mick.niklas@gmail.com>\r\nCo-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>"
}
 13221727 https://github.com/pydata/xarray/pull/6403  

Links from other tables