home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 840454257

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
840454257 PR_kwDOAMm_X84yGFBx 6237 closed 0 Enable running sphinx-build on Windows 38358698 - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` This PR enables one to build the documentation on Windows by manually invoking `sphinx-build`. The first commit enables *sphinx* to execute the "conf.py" file. Before the commit, *sphinx* complains: ``` Configuration error: There is a programmable error in your configuration file: ``` with the exception `FileNotFoundError: [WinError 2] The system cannot find the file specified` where it tries to invoke *conda*. On Windows, *conda* environments other than the base environment have "conda.bat" on their path rather than "conda.exe", and one must call `subprocess.run` with "conda.bat" instead of merely "conda". However, the `CONDA_EXE` environment variable correctly points to the executable and should do so across platforms; it requires *conda* version 4.5 or later for conda/conda#6923. The second commit enables the build to tolerate exceptions when deleting temporary files and tells Git to ignore more such files. Without the commit, builds occasionally failed at the `os.remove` calls with exceptions such as `PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'example.nc'`. Should "whats-new.rst" mention these changes, which are developer-visible but not user-visible? I welcome any feedback. Edit: Checked the "whats-new" task. 2022-02-04T17:15:14Z 2022-03-04T19:15:42Z 2022-03-01T16:00:34Z 2022-03-01T16:00:34Z 0f91f05e532f4424f3d6afd6e6d5bd5a02ceed55     0 2c0a29c98e9ebb5b5a2001b155bd15d85fd27797 33067cd24f66d4855babaa6801b009480c4e2cb2 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/6237  

Links from other tables

  • 1 row from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.614ms