pull_requests: 838161344
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 838161344 | PR_kwDOAMm_X84x9VPA | 6232 | closed | 0 | Amended docstring to reflect the actual behaviour of Dataset.map | 14276158 | In [MetPy/pull#2312](https://github.com/MetPy/pull/2312), I noticed that the behavior of `Dataset.map`'s kwarg `keep_attrs` was not in line with its docstring. This is because in xarray 0.16.2 (pydata/xarray#3595 & pydata/xarray#4195) this behavior was changed. In short, `keep_attrs=True` now copies both, the Dataset's and the variables' attributes and adds them to the new objects - preventing any change to them by the mapped function. In contrast, `keep_attrs= False` discards the Dataset's attributes and does not touch the variables' attributes, enabling the mapped function to modify them. Here, I propose an update to the `keep_attrs` docstring of `Dataset.map` which would more accurately reflect its current behavior. Please feel free to provide alternative formulations if you feel like this one misses the mark. | 2022-02-02T10:39:30Z | 2022-02-23T09:51:41Z | 2022-02-23T09:51:27Z | 2022-02-23T09:51:27Z | b760807646cce493cf8f4f619fcda9a14e84670f | 0 | 0dacffa52cd3f32d8871c87369f5269743f46e0b | 86328a1cfe5296f8e478b17e52ba884db2384872 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/6232 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests