pull_requests: 811230470
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 811230470 | PR_kwDOAMm_X84wWmUG | 6123 | closed | 0 | assert ds errors in test_dataset.py | 3698640 | a number of assert statements in test_dataset.py::test_clip make assertions which will never fail as long as there is at least one data_variable: ```python assert result.min(...) >= 0.5 ``` this evaluates to datasets with scalar True or False values in each data_variable; however, `ds.__bool__` returns true if `len(ds.data_vars) > 0`. related: https://github.com/pydata/xarray/pull/6122 No workflow stages here - I just made the changes in the browser. Pretty simple patch that increases the effectiveness of existing tests - no changes to the xarray core code. Let me know if you'd like me to implement any of the normal checks. | 2021-12-29T02:24:21Z | 2021-12-31T22:22:16Z | 2021-12-29T06:17:33Z | 2021-12-29T06:17:33Z | 6b11d6e80a2445f2e1e7c4d5895008f7c845c4d5 | 0 | 5f18b8803b905fa46c76f53c4b205eab8d3fdb13 | 5d30f96e94de6922a01ad240dec65d2810e19ea0 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/6123 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests