pull_requests: 811226240
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
811226240 | PR_kwDOAMm_X84wWlSA | 6122 | closed | 0 | assert ds errors in test_backends | 3698640 | Makes four changes to xarray/tests/test_backends.py::test_open_fsspec Previously, there were four inequality tests which will always pass regardless of whether the read was successful. `assert ds0 == ds2` will always evaluate to True if the datasets have at least one data variable. Instead, xr.testing.assert_equal should be used to test data variable equality. No workflow stages here - I just made the changes in the browser. Pretty simple patch that increases the effectiveness of existing tests - no changes to the xarray core code. | 2021-12-29T02:06:23Z | 2021-12-31T22:21:55Z | 2021-12-29T06:24:50Z | 2021-12-29T06:24:50Z | 92ac89f8a19368d1e6d18529997f68661e8e7784 | 0 | 12d508551beb7fbab636198577b2b142776e44f1 | 5d30f96e94de6922a01ad240dec65d2810e19ea0 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/6122 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests