pull_requests: 792946756
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 792946756 | PR_kwDOAMm_X84vQ2hE | 6037 | closed | 0 | Fix wrong typing for tolerance in reindex | 57914115 | In the `xarray.core.dataset.py `module, more particulary in the reindex method the tolerance argument is set to be a `Number` https://github.com/pydata/xarray/blob/f08672847abec18f46df75e2f620646d27fa41a2/xarray/core/dataset.py#L2743 But the `_reindex` function call `reindex_variable` function. In the `reindex_variable` the type for tolerance is `Any`. This function ends to call `get_indexer_nd` which call the pandas function `get_indexer` : https://github.com/pydata/xarray/blob/f08672847abec18f46df75e2f620646d27fa41a2/xarray/core/indexes.py#L137 In pandas the type of tolerance according to the docs can be a scalar or a list-like object - [x] Tests added - [x] Passes `pre-commit run --all-files` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` | 2021-12-01T17:19:08Z | 2022-01-15T17:28:08Z | 2022-01-15T17:27:56Z | 2022-01-15T17:27:56Z | 3666a6fb7226601002f408d56e81837ab69b8d4e | 0 | c659cc4f8738900e9c11a5407b8f4cdc801613d5 | 4c865d607e6e03605b7050d9fb6991e86346bf08 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/6037 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests