pull_requests: 760488221
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 760488221 | PR_kwDOAMm_X84tVCEd | 5875 | closed | 0 | fix test with pseudonetcdf 3.2 | 10194086 | Fixes one part of #5872 pseudoNETCDF adds two attrs to ict files, which breaks the following two tests: Test 1: https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/tests/test_backends.py#L3944 Test 2: https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/tests/test_backends.py#L4030 I reproduced the test file so that the tests pass again. To reproduce the file I used the following bit of code: ```python import xarray as xr from xarray.tests import test_backends fN = "xarray/tests/data/example.ict" fmtkw = {"format": "ffi1001"} ds = xr.open_dataset(fN, engine="pseudonetcdf", backend_kwargs={"format": "ffi1001"}) c = test_backends.TestPseudoNetCDFFormat() c.save(ds, fN, **fmtkw) ``` The `save` method is here: https://github.com/pydata/xarray/blob/07de257c5884df49335496ee6347fb633a7c302c/xarray/tests/test_backends.py#L4124 @barronh I would appreciate your review here - I am not sure if this is the right approach. | 2021-10-18T13:49:23Z | 2021-10-22T21:24:09Z | 2021-10-22T21:23:34Z | 2021-10-22T21:23:34Z | 29e38db1758d522e220a1407079c6bac9ef691d2 | 0 | d72c3be1d25ab1cefad057b391fc7157043e35c1 | 07de257c5884df49335496ee6347fb633a7c302c | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/5875 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests