pull_requests: 697307477
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
697307477 | MDExOlB1bGxSZXF1ZXN0Njk3MzA3NDc3 | 5636 | closed | 0 | Refactor index vs. coordinate variable(s) | 4160723 | <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #5553 - [x] Tests added - [x] Passes `pre-commit run --all-files` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` This implements option 3 (sort of) described in https://github.com/pydata/xarray/issues/5553#issue-933551030: - the goal is to avoid wrapping an `xarray.Index` into an `xarray.Variable` and keep those two concepts distinct from each other. - the `xarray.Index.from_variables` class constructor accepts a dictionary of `xarray.Variable` objects as argument and may (or should?) also return corresponding `xarray.IndexVariable` objects to ensure immutability. - for `PandasIndex`, the new returned `xarray.IndexVariable` wraps the underlying `pd.Index` via a `PandasIndexingAdapter` (this reverts some changes made in #5102). - for `PandasMultiIndex`, this PR adds `PandasMultiIndexingAdapter` so that we can wrap the pandas multi-index in separate coordinate variables objects: one for the dimension + one for each level. The level coordinates data internally hold a reference to the dimension coordinate data to avoid indexing the same underlying `pd.MultiIndex` for each of those coordinates (`PandasMultiIndexingAdapter.__getitem__` is memoized for that purpose). This is very much work in progress, I need to update (or revert) all related parts of Xarray's internals, update tests, etc. At this stage any comment on the approach described above is welcome. | 2021-07-26T19:54:25Z | 2023-08-30T09:21:55Z | 2021-08-09T07:56:56Z | 2021-08-09T07:56:56Z | 4bb9d9c6df77137f05e85c7cc6508fe7a93dc0e4 | 0 | e5f2502c07bd7ad449f9f6acfd0e6ac3ede92fb9 | 8b95da8e21a9d31de9f79cb0506720595f49e1dd | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/5636 |
Links from other tables
- 2 rows from pull_requests_id in labels_pull_requests