pull_requests: 676486834

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
676486834 MDExOlB1bGxSZXF1ZXN0Njc2NDg2ODM0 5519 closed 0 Type hints for combine functions 35968931 Added type hints to `combine_nested` and `combine_by_coords`. Builds on #4696 because that PR generalised the argument types to include DataArrays, but I couldn't see that branch in the list to base this PR off of. The "nested list-of-lists" argument to `combine_nested` opens up a can of worms: the only way I can see to specify the type of a nested list of arbitrary depth is to [define the type recursively](https://stackoverflow.com/a/53845083/3154101), but [mypy does not currently support recursive type definitions](https://github.com/python/mypy/issues/731), though some other type checkers can, e.g. [Microsoft's Pylance does](https://devblogs.microsoft.com/python/pylance-introduces-five-new-features-that-enable-type-magic-for-python-developers/). We're going to have the same problem when specifying types for `open_mfdataset`. For now this problem is just ignored by the type checker, meaning that we don't actually check the type of the nested-list-of-lists. - [x] Passes `pre-commit run --all-files` - [ ] ~~User visible changes (including notable bug fixes) are documented in `whats-new.rst`~~ 2021-06-23T17:33:36Z 2021-09-30T20:16:45Z 2021-09-30T19:52:47Z 2021-09-30T19:52:47Z 043d68bd1c285245cdfe2282cec42c5843e4ed44     0 2cd5a5d598737e9e1c7cd001fa9468c823a1d0dd 434090909dfad3e77df2488ab957ceb650045285 MEMBER   13221727 https://github.com/pydata/xarray/pull/5519  

Links from other tables