pull_requests: 662632726

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
662632726 MDExOlB1bGxSZXF1ZXN0NjYyNjMyNzI2 5440 closed 0 Consistent chunking after broadcasting 22245117 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #5435 - [ ] Tests added - [x] Passes `pre-commit run --all-files` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` I think it does the job, although I'm not sure whether this is the best approach. A couple of questions: 1. I should probably add a test. Where is the best place? `test_dask`? 2. I added a `chunks` arguments in `set_dims`. I haven't updated the docstring yet... i) `shape` is not in the docstring either, is it because it is not meant to be public? If yes, I guess we can omit `chunks` as well. ii) The `chunks` argument I've introduced must be a dict mapping dim to chunks. Is that a problem since `chunks` is used elsewhere and can be slightly different (e.g., just an integer, 'auto'). iii) Should I add a check and raise an error if `chunks` is not a dictionary or is missing dimensions? 2021-06-05T22:27:39Z 2021-06-21T08:53:12Z 2021-06-21T08:53:09Z   5957d1dc21ef59f30456b44443082772e3662657     0 1cce3bcd48f66f524f4d26bc7b2aa4a8e1586f0a 36cb33715f8d141fce7bcbe9eafca75a9f2f0bfa CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/5440  

Links from other tables