pull_requests: 638381352
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 638381352 | MDExOlB1bGxSZXF1ZXN0NjM4MzgxMzUy | 5288 | closed | 0 | Raise error for invalid reference date for encoding time units | 44147817 | - [x] Closes #5199 - [x] Tests added - [x] Passes `pre-commit run --all-files` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` Although the error raised by this commit does not include the whole units string, I believe it is actually more useful and specific since it focuses on the part (reference date) that's actually causing the problem. Also, the reference date is the only information available in `coding.times._ensure_padded_year`, so this is the simplest way of raising an error. I had a look in `tests/test_coding_times.py` and could not find a test for this related error raising (since I'd put a test for this commit around there) https://github.com/pydata/xarray/blob/234b40a37e484a795e6b12916315c80d70570b27/xarray/coding/times.py#L127-L129 Have I missed it? EDIT: I've tried to substitute the error raise on line 129 with a `pass` and all the tests passed anyway. | 2021-05-10T20:25:23Z | 2021-05-14T09:43:30Z | 2021-05-13T18:27:13Z | 2021-05-13T18:27:13Z | 0a29ef896f6a79be2d36394dcb02857f69e0f170 | 0 | 701aeee15f06b36b3d3c968cea8002162d7a89eb | 751f76ac95761e18d2bf2b5c7ac3c84bd2ee69ea | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/5288 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests