home / github / pull_requests

Menu
  • Search all tables
  • GraphQL API

pull_requests: 631629726

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
631629726 MDExOlB1bGxSZXF1ZXN0NjMxNjI5NzI2 5271 closed 0 Ensure `HighLevelGraph` layers are `Layer` instances 11656932 This PR updates how we construct the `HighLevelGraph` in `subset_dataset_to_block`. Currently we create a `HighLevelGraph` and then manually add a few new layers, which are `dict`s, directly to `hlg.layers`. https://github.com/pydata/xarray/blob/eec2b59bd08498fe3d50d8549b540d0a8409c7ac/xarray/core/parallel.py#L537-L546 However since (in more recent versions of Dask) [`HighLevelGraph` layers are expected to be `Layer` class instances](https://github.com/dask/dask/blob/23c93d72c8fbd194b44614c29dd584ff93fc1eef/dask/highlevelgraph.py#L578-L582) this can result in unexpected errors (xref https://github.com/pydata/xarray/issues/5077#issuecomment-832359943). Instead of manually adding new layers to `hlg.layers`, this PR proposes we create a new `HighLevelGraph` altogether to ensure that `hlg.layers` won't contain any raw `dict` layers. 2021-05-06T16:46:48Z 2021-05-06T20:37:42Z 2021-05-06T20:29:55Z 2021-05-06T20:29:55Z 020345debdff999839aab3e2b6409d30407f3348     0 57dffd447bafe81e1e72760eeebc4030a972679b eec2b59bd08498fe3d50d8549b540d0a8409c7ac CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/5271  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.803ms