pull_requests: 617378253

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
617378253 MDExOlB1bGxSZXF1ZXN0NjE3Mzc4MjUz 5180 closed 0 Convert calendar to lowercase in standard calendar checks 6628425 This fixes the issue in #5093, by ensuring that we always convert the calendar to lowercase before checking if it is one of the standard calendars in the decoding and encoding process. I've been careful to test that the calendar attribute is faithfully roundtripped despite this, uppercase letters and all. ~~I think part of the reason this went unnoticed for a while was that we could still decode times like this if cftime was installed; it is only in the case when cftime was not installed that our logic failed. This is because `cftime.num2date` already converts the calendar to lowercase internally.~~ Upon re-reading @pont-us's issue description, while it didn't cause an error, the behavior was incorrect with cftime installed too. I updated the test to check the dtype is `np.datetime64` as well. - [x] Closes #5093 - [x] Tests added - [x] Passes `pre-commit run --all-files` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` 2021-04-17T20:44:57Z 2021-04-18T10:17:11Z 2021-04-18T10:17:08Z 2021-04-18T10:17:08Z 44f4ae11019ca9c9e7280c41d9d2fd86cf86ccce     0 87cf204615e5fbeebcc9f3ba4793f918ee74dfc4 c54ec94a6e4c3276eac3e2bbea3c77a040d5674a MEMBER   13221727 https://github.com/pydata/xarray/pull/5180  

Links from other tables