pull_requests: 614408343
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 614408343 | MDExOlB1bGxSZXF1ZXN0NjE0NDA4MzQz | 5149 | closed | 0 | Convert attribute and dimension names to strings when generating HTML repr | 367900 | The standard repr() already handled non-string attribute names, but the HTML formatter failed when trying to escape HTML entitites in non-string names. This just calls str() before escape(). It also includes tests for Dataset, DataArray and Variable. Reported in #5146. ~~Note that there may be a need to do the same for dimension names if they are allowed to be strings. Currently dimensions must be created as strings but can later be renamed to non-strings, see #5148.~~ Dimensions can be non-str, updated. <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Tests added - [x] Passes `pre-commit run --all-files` | 2021-04-13T12:14:03Z | 2021-05-04T03:39:00Z | 2021-05-04T03:38:53Z | 2021-05-04T03:38:52Z | 1c198a191127c601d091213c4b3292a8bb3054e1 | 0 | ec2c42944303240436f98587817d464116cbf05c | 9ce95a8ef3e63f553da33d4df7ed92afc5f182bb | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/5149 |
Links from other tables
- 1 row from pull_requests_id in labels_pull_requests