pull_requests: 611752657

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
611752657 MDExOlB1bGxSZXF1ZXN0NjExNzUyNjU3 5136 closed 0 Fix broken engine breakes xarray.open_dataset 35919497 Currently, a broken engine breaks xarray.open_dataset. I have added a `try except` to avoid this problem. Old behaviour: ```python >>> ds = xr.open_dataset('example.nc') Traceback (most recent call last): File "/usr/local/Caskroom/miniconda/base/envs/xarray/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3331, in run_code exec(code_obj, self.user_global_ns, self.user_ns) File "<ipython-input-3-0c694cae8262>", line 1, in <module> arr = xr.open_dataset("example.nc") File "/Users/barghini/devel/xarray/xarray/backends/api.py", line 495, in open_dataset backend = plugins.get_backend(engine) File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 115, in get_backend engines = list_engines() File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 97, in list_engines return build_engines(pkg_entrypoints) File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 84, in build_engines external_backend_entrypoints = backends_dict_from_pkg(pkg_entrypoints) File "/Users/barghini/devel/xarray/xarray/backends/plugins.py", line 58, in backends_dict_from_pkg backend = pkg_ep.load() File "/usr/local/Caskroom/miniconda/base/envs/xarray/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2450, in load return self.resolve() File "/usr/local/Caskroom/miniconda/base/envs/xarray/lib/python3.8/site-packages/pkg_resources/__init__.py", line 2456, in resolve module = __import__(self.module_name, fromlist=['__name__'], level=0) File "/Users/barghini/devel/xarray-sentinel/xarray_sentinel/sentinel1.py", line 13 ERROR ^ SyntaxError: invalid syntax ``` New behaviour: ```python >>> ds = xr.open_dataset('example.nc') /Users/barghini/devel/xarray/xarray/backends/plugins.py:61: RuntimeWarning: Engine sentinel-1 loading failed: name 'ERROR' is not defined warnings.warn(f"Engine {name} loading failed:\n{ex}", RuntimeWarning) ``` - [x] Tests added - [x] Passes `pre-commit run --all-files` 2021-04-08T17:47:12Z 2021-04-10T23:55:04Z 2021-04-10T23:55:01Z 2021-04-10T23:55:01Z 32ccc93e899ac083834127ca382204b467ed89a3     0 a3996fb78c195b61e4d9acfd1fa71d0a6bcbc204 7e48aefd3fd280389dee0fc103843c6ad7561e2b COLLABORATOR   13221727 https://github.com/pydata/xarray/pull/5136  

Links from other tables