home / github / pull_requests

Menu
  • GraphQL API
  • Search all tables

pull_requests: 606230215

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
606230215 MDExOlB1bGxSZXF1ZXN0NjA2MjMwMjE1 5099 closed 0 Use broadcast_like for 2d plot coordinates 3958036 Use broadcast_like if either `x` or `y` inputs are 2d to ensure that both have dimensions in the same order as the DataArray being plotted. Convert to numpy arrays after possibly using broadcast_like. Simplifies code, and fixes #5097 (bug when dimensions have the same size). @dcherian > IIRC the "resolving intervals" section later will break and is somewhat annoying to fix. This is why the current ugly code exists. This change seems to 'just work', and unit tests pass. Is there some extra check that needs doing to make sure "resolving intervals" is behaving correctly? I can't think of a unit test that would have caught #5097, since even when the bug happens, a plot is produced without errors or warnings. If anyone has an idea, suggestions/pushes welcome! <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #5097 - [ ] Tests added - [x] Passes `pre-commit run --all-files` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` 2021-03-31T19:34:32Z 2021-04-22T07:16:17Z 2021-04-22T07:16:17Z 2021-04-22T07:16:17Z b2351cbe3f3e92f0e242312dae5791fc83a4467a     0 8a331c39831085c7f93cef0e760b204dde384370 ddc352faa6de91f266a1749773d08ae8d6f09683 CONTRIBUTOR   13221727 https://github.com/pydata/xarray/pull/5099  

Links from other tables

  • 0 rows from pull_requests_id in labels_pull_requests
Powered by Datasette · Queries took 0.723ms