pull_requests: 577425672
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 577425672 | MDExOlB1bGxSZXF1ZXN0NTc3NDI1Njcy | 4941 | closed | 0 | Use definition of DTypeLike from Numpy if found | 548266 | This allows application of numpy ufuncs to DataArrays to typecheck correctly with Numpy 1.20 E.g. without this fix: ``` import xarray as xr import numpy as np def applyufunctodataarray() -> xr.DataArray: a = xr.DataArray(np.array([-1,2,3])) b = np.abs(a) return b ``` will result in: ``` test.py:9: error: Argument 1 to "__call__" of "ufunc" has incompatible type "DataArray"; expected "Union[Union[int, float, complex, str, bytes, generic], Sequence[Union[int, float, complex, str, bytes, generic]], Sequence[Sequence[Any]], _SupportsArray]" Found 1 error in 1 file (checked 1 source file) ``` While it will type check without issues with this fix. I have not yet documented this or added tests. Please let me know if this change is acceptable and I am happy to do that. - [ ] Tests added - [x] Passes `pre-commit run --all-files` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` | 2021-02-22T08:06:40Z | 2021-02-23T19:31:14Z | 2021-02-23T19:20:55Z | 2021-02-23T19:20:55Z | 348eb481976673ea772bb8424dd2c3c33c0356c2 | 0 | 35c36b87bb6937c45c4ae6b5564973f89214d216 | 88c5fd2638cd731fa90014a5b0f376ab190441d7 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/4941 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests