pull_requests: 550762631
This data as json
| id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 550762631 | MDExOlB1bGxSZXF1ZXN0NTUwNzYyNjMx | 4774 | closed | 0 | improve typing of OrderedSet | 32801740 | - [x] Passes `isort . && black . && mypy . && flake8` Small patch to improve typing of OrderedSet: allowing more general input type in its constructor and .update method (Iterator instead of AbstractSet) helps to get rid of ``# type: ignore``. Side-effect: some performance gain in micro-benchmark (before and after): ``` %timeit xr.core.utils.OrderedSet(range(10)) 3.46 µs ± 5.37 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each) ``` ``` 2.06 µs ± 6.39 ns per loop (mean ± std. dev. of 7 runs, 100000 loops each) ``` | 2021-01-07T01:20:56Z | 2021-01-07T23:28:53Z | 2021-01-07T23:28:48Z | 2021-01-07T23:28:48Z | 1ae977867b59d5075df4b21f3ce61e3221e7cb87 | 0 | 0cc4e6ec58db285f28508c256be3cc380763ba29 | bc49e277a45212f7ef33165d7fa1247c219ce276 | CONTRIBUTOR | 13221727 | https://github.com/pydata/xarray/pull/4774 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests