pull_requests: 548225043

This data as json

id node_id number state locked title user body created_at updated_at closed_at merged_at merge_commit_sha assignee milestone draft head base author_association auto_merge repo url merged_by
548225043 MDExOlB1bGxSZXF1ZXN0NTQ4MjI1MDQz 4760 closed 0 WIP: testing.assert_* check dtype 10194086 <!-- Feel free to remove check-list items aren't relevant to your change --> - [x] Closes #4727 - [ ] Tests added - [ ] Passes `isort . && black . && mypy . && flake8` - [ ] User visible changes (including notable bug fixes) are documented in `whats-new.rst` - [ ] New functions/methods are listed in `api.rst` --- This adds a dtype check for `equal`, `identical`, `broadcast_equal`, and the `xr.testing.assert_*` functions. It is far from complete: tests and documentation are still missing, but I wanted to get it online for feedback. When I set `check_dtype=True` there are around 600 failures. Fixing that is for another PR. #4759 should help a bit. - [ ] I added the checks to `lazy_array_equiv`, however, sometimes dask can get the dtype wrong before the compute (see below). Do you think I need to put it in the non-lazy part? ```python import numpy as np import xarray as xr da = xr.DataArray(np.array([0, np.nan], dtype=object)).chunk() da.prod().dtype # -> dtype('O') da.prod().compute().dtype # -> dtype('int64') ``` - [ ] `check_dtype` is still missing from `assert_duckarray_allclose` & `assert_duckarray_equal` - do you think there are required? - [ ] The dtypes of array elements are not tested (see below). I don't think I'll implement that here. ```python da0 = xr.DataArray(np.array([0], dtype=object)) da1 = xr.DataArray(np.array([0.], dtype=object)) xr.testting.assert_equal(da0, da1, check_dtype=True) ``` 2021-01-04T12:45:00Z 2022-01-26T08:41:17Z 2021-10-18T14:06:38Z   0d1ec605581a431a3af7d992f7a73f4120af3a97     1 acacfb0c784e5fb66f282423b5bb95e9b9d82545 2bb5d20fb2b4158390ab05aa6bf598b78f2caa9d MEMBER   13221727 https://github.com/pydata/xarray/pull/4760  

Links from other tables