pull_requests: 547961795
This data as json
id | node_id | number | state | locked | title | user | body | created_at | updated_at | closed_at | merged_at | merge_commit_sha | assignee | milestone | draft | head | base | author_association | auto_merge | repo | url | merged_by |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
547961795 | MDExOlB1bGxSZXF1ZXN0NTQ3OTYxNzk1 | 4758 | closed | 0 | Ensure maximum accuracy when encoding and decoding cftime.datetime values | 6628425 | - [x] Closes #4097 - [x] Tests added - [x] Passes `isort . && black . && mypy . && flake8` - [x] User visible changes (including notable bug fixes) are documented in `whats-new.rst` Following up on #4684, this PR makes changes to our encoding / decoding process such that `cftime.datetime` objects can be roundtripped exactly. In the process, because it made the tests cleaner to define, I added cftime offsets for millisecond and microsecond frequency as well. As I note in the what's new, exact roundtripping requires cftime of at least version 1.4.1, which included improvements to `cftime.num2date` (https://github.com/Unidata/cftime/pull/176, https://github.com/Unidata/cftime/pull/188) and `cftime.date2num` (https://github.com/Unidata/cftime/pull/178, https://github.com/Unidata/cftime/pull/225). | 2021-01-04T00:47:32Z | 2021-02-10T21:52:16Z | 2021-02-10T21:44:26Z | 2021-02-10T21:44:25Z | 10f0227a1667c5ab3c88465ff1572065322cde77 | 0 | 725bcabb8c965f8829f2b82a245789eec0cbc0a6 | 46591d28d9fbbfc184aaf4075d330b1c8f070627 | MEMBER | 13221727 | https://github.com/pydata/xarray/pull/4758 |
Links from other tables
- 0 rows from pull_requests_id in labels_pull_requests